Skip to content

some potential bug_fixes

Robert Elia requested to merge bug_fixes into main

Description

I don't think records was actually getting updated. A series was updated and returned but never used. Added a check for "type" in the manager workflow Seemed like rearranging the system tests helped with getting them passing /shrug (not sure why since it appears to be doing setup/teardown for each test) one of the system tests updates the "type" but then goes on to validate that it was updated to "Newname"

Changes Made

  • Change 1: ^^ the list above

Test Plan

  • Ran all unit tests (only unit) 100%

  • Ran all system manager tests 100%

  • Ran all system provider tests 100%

  • Ran all system manager and provider tests 15/17 pass

  • Ran all system and unit tests 238/240 pass

  • List the steps or commands needed to validate the changes.

  • Specify any test data or configurations required.

Checklist

  • Code follows the project's coding style and conventions.
  • Automated tests for the changes have been added or existing tests have been updated.
  • Code coverage for new or modified code is maintained or improved.
  • The code builds and runs without errors or warnings.
  • Documentation has been updated to reflect the changes made.
  • All discussions and feedback on the PR have been addressed.
  • CI/CD pipelines pass successfully, including any required checks or tests.
  • The PR has been reviewed and approved by the designated reviewers.

Merge request reports