Skip to content

Fixed type errors in generate_member_report

Danny Love requested to merge generate-member-report-fixes into main

Fixed type errors in generate_member_report

I found some type issues in generate_member_report while writing system tests. Issues were previously missed due to mocking.

Related Issue(s)

Changes Made

  • Change 1: Changed time comparison type in gt_cols from datetime to date
  • Change 2: Removed gt_cols from irrelevant functions
  • Change 3: Changed expected_df to contain the correct values

Test Plan

  • make test

Checklist

  • Code follows the project's coding style and conventions.
  • Automated tests for the changes have been added or existing tests have been updated.
  • Code coverage for new or modified code is maintained or improved.
  • The code builds and runs without errors or warnings.
  • Documentation has been updated to reflect the changes made.
  • All discussions and feedback on the PR have been addressed.
  • CI/CD pipelines pass successfully, including any required checks or tests.
  • The PR has been reviewed and approved by the designated reviewers.
Edited by Robert Elia

Merge request reports

Loading